Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/roslyn-analyzers #106072

Merged
merged 2 commits into from
Aug 10, 2024
Merged

[main] Update dependencies from dotnet/roslyn-analyzers #106072

merged 2 commits into from
Aug 10, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 7, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn-analyzers

  • Subscription: 5465c78f-1281-49a8-f9b0-08d9301a7704
  • Build: 20240805.1
  • Date Produced: August 6, 2024 7:56:45 AM UTC
  • Commit: 3211f48253bc18560156d90dc5e710d35f7d03fa
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
5ac6955 
…uild 20240805.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24402.1 -> To Version 3.11.0-beta1.24405.1
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Aug 7, 2024
This was referenced Aug 7, 2024
Open
Open
Open
Open
Open
Open
Closed
Open
Open
Open
@lewing
Copy link
Member

lewing commented Aug 8, 2024 

  at System.Delegate.<BindToMethodInfo>g____PInvoke|21_0(System.Runtime.CompilerServices.ObjectHandleOnStack, System.Runtime.CompilerServices.ObjectHandleOnStack, System.RuntimeMethodHandleInternal, System.Runtime.CompilerServices.QCallTypeHandle, System.DelegateBindingFlags)
   at System.Reflection.RuntimeMethodInfo.CreateDelegateInternal(System.Type, System.Object, System.DelegateBindingFlags)
   at System.Linq.Expressions.Interpreter.FuncCallInstruction`2[[System.__Canon, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Int32, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]]..ctor(System.Reflection.MethodInfo)
   at System.RuntimeMethodHandle.InvokeMethod(System.Object, Void**, System.Signature, Boolean)
   at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(System.Object, System.Span`1<System.Object>, System.Reflection.BindingFlags)
   at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(System.Object, System.Reflection.BindingFlags, System.Reflection.Binder, System.Object[], System.Globalization.CultureInfo)
   at System.Reflection.RuntimeConstructorInfo.Invoke(System.Reflection.BindingFlags, System.Reflection.Binder, System.Object[], System.Globalization.CultureInfo)
   at System.RuntimeType.CreateInstanceImpl(System.Reflection.BindingFlags, System.Reflection.Binder, System.Object[], System.Globalization.CultureInfo)
   at System.Activator.CreateInstance(System.Type, System.Object[])

cc @jeffschwMSFT

@lewing
Copy link
Member

lewing commented Aug 8, 2024

@mangod9 this looks like reflection and not related to the flow but I didn't want to open a known issue without checking

@mangod9
Copy link
Member

mangod9 commented Aug 8, 2024

Adding @ericstj who owns reflection. I havent seen this particular failure before. Is it consistent?

@ericstj
Copy link
Member

ericstj commented Aug 9, 2024

This is in the VM:

runtime/src/coreclr/vm/comdelegate.cpp

Line 992 in 4bd1492

extern "C" BOOL QCALLTYPE Delegate_BindToMethodInfo(QCall::ObjectHandleOnStack d, QCall::ObjectHandleOnStack target,

There's a log with dump analysis
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-106072-merge-835c24e1c7e8458e8f/System.Linq.Expressions.Tests/1/console.27df0834.log?helixlogtype=result

It claims an access violation here:

(778.1de4): Access violation - code c0000005 (first/second chance not available)
For analysis of this file, run !analyze -v
*** WARNING: Unable to verify checksum for coreclr.dll
coreclr!Stub::HasExternalEntryPoint [inlined in coreclr!COMDelegate::BindToMethod+0xcb]:
00007ffb`fc169d63 f7400400000040  test    dword ptr [rax+4],40000000h ds:00007ffb`9e30f004=????????

(Inline Function) --------`-------- coreclr!Stub::HasExternalEntryPoint
(Inline Function) --------`-------- coreclr!Stub::GetEntryPointInternal
(Inline Function) --------`-------- coreclr!Stub::GetEntryPoint
00000017`93e7b510 00007ffb`fc16a0d8 coreclr!COMDelegate::BindToMethod+0xcb

Can someone from runtimne have a look? @jkotas @AaronRobinsonMSFT

@ericstj
Copy link
Member

ericstj commented Aug 9, 2024 •
edited
Loading

Seems like same symptom as #55536.

I wish we had the dump here - it seems like it wasn't uploaded @carlossanlop @hoyosjs

@AaronRobinsonMSFT
Copy link
Member

Taking a look.

@jkotas
Copy link
Member

jkotas commented Aug 9, 2024

I think it is a regression introduced by #105480 .

@jkotas
Copy link
Member

jkotas commented Aug 9, 2024

I think it is a regression introduced by #105480 .

Pushed a revert

@jkotas jkotas mentioned this pull request Aug 9, 2024
Open
@hoyosjs
Copy link
Member

hoyosjs commented Aug 9, 2024

@ericstj - I see a dump dotnet.exe.7864.dmp and for your particular one dotnet.exe.1912.dmp

This was referenced Aug 9, 2024
Closed
Open
Closed
@ericstj
Copy link
Member

ericstj commented Aug 9, 2024

@ericstj - I see a dump dotnet.exe.7864.dmp and for your particular one dotnet.exe.1912.dmp

Huh, for some reason I couldn't see in the test tab, nor would runfo pull it down. How did you find that?

@mangod9 mangod9 mentioned this pull request Aug 9, 2024
Closed
@mangod9
Copy link
Member

mangod9 commented Aug 9, 2024

@ericstj - I see a dump dotnet.exe.7864.dmp and for your particular one dotnet.exe.1912.dmp

Huh, for some reason I couldn't see in the test tab, nor would runfo pull it down. How did you find that?

@cshung had also hit an issue where the dump was not available where it should have been collected. Perhaps some generic issue here?

@jkotas
Copy link
Member

jkotas commented Aug 10, 2024

Huh, for some reason I couldn't see in the test tab, nor would runfo pull it down. How did you find that?

If you did not see the test tab, it is a problem in AzDo. The AzDo is responsible to show the test tab.

I can see the test tab fine for the both the Windows and Linux crashes earlier, and runfo command worked fine too.

https://dev.azure.com/dnceng-public/public/_build/results?buildId=768489&view=ms.vss-test-web.build-test-results-tab&runId=19613134&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab&resultId=218254

https://dev.azure.com/dnceng-public/public/_build/results?buildId=768489&view=ms.vss-test-web.build-test-results-tab&runId=19614930&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab&resultId=218646

@cshung had also hit an issue where the dump was not available where it should have been collected. Perhaps some generic issue here?

We have several generic issues with collecting dumps (e.g. dumps not collected for build crashes). There are tracking issues opened for the known generic issues. But I do not see an issue with collecting crash dumps in this PR.

jkotas
jkotas approved these changes Aug 10, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All failures are known issues according to the build analysis

@jkotas jkotas merged commit b2f0e36 into main Aug 10, 2024
157 of 162 checks passed
@jkotas jkotas deleted the darc-main-ef4e3739-4051-460a-95f9-16d338f7e8f9 branch August 10, 2024 00:46
@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this pull request Aug 21, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lewing @mangod9 @ericstj @AaronRobinsonMSFT @jkotas @hoyosjs